fix(skin-market): add desktop and website links - #2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type and Areas
Type: bug fix / UI/UX / test / CI
Areas: Skin Market web, Web UI Appearance contract
Motivation / Impact
Skin Market visitors can now reach the BitFun Desktop downloads directly from the installation guidance and navigate to the BitFun official website from the footer. The client manual-upload channel from #2017 also satisfies the Appearance contract audit used by CI.
Verification
pnpm --dir src/skin-market-web run type-check— passedpnpm --dir src/skin-market-web run test— 5 files / 15 tests passedpnpm --dir src/skin-market-web run build— passedpnpm run appearance:contract-audit— passedpnpm run build:web— passed (includes Appearance audit, type-check, Vite production build, and Monaco asset verification)git diff --check— passed31551b797515d99c8b315b04abeacb2b5ec3ad56tomarket.openbitfun.com/skin; origin/public health and both external URLs in the served asset were verified.Reviewer Notes
AI-assisted, fully tested. The manual Skin submission feature requested alongside this work is present in current
mainvia #2017; this PR fixes its missing Appearance surface registration after the first CI run exposed it.Checklist